Commit 4d1566ed authored Mar 19, 2008 by Kay Sievers Committed by James Bottomley Mar 19, 2008

[SCSI] fix media change events for polled devices



Commit:
  a341cd0f (SCSI: add asynchronous event notification API)
breaks:
  285e9670 (sr,sd: send media state change modification events)
by introducing an event filter, which is removed here, to make
events, we are depending on, happen again.

Fix this by removing the event filter.  It's pretty much broken at the
moment, since a user can't set it (the attribute being read only).  A
proper fix will be to make the event discriminator distinguish between
AN and Polled media change events.

Cc: David Zeuthen <david@fubar.dk>
Cc: kristen accardi <kaccardi@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

parent c02e6002

drivers/scsi/scsi_lib.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -2162,10 +2162,15 @@ void sdev_evt_send(struct scsi_device sdev, struct scsi_event evt)
		{
		unsigned long flags;

		#if 0
		/* FIXME: currently this check eliminates all media change events
		* for polled devices. Need to update to discriminate between AN
		* and polled events */
		if (!test_bit(evt->evt_type, sdev->supported_events)) {
		kfree(evt);
		return;
		}
		#endif

		spin_lock_irqsave(&sdev->list_lock, flags);
		list_add_tail(&evt->node, &sdev->event_list);

Admin message