Commit 4d0e3230 authored Sep 23, 2019 by Qian Cai Committed by Linus Torvalds Sep 24, 2019

mm/memcontrol.c: fix a -Wunused-function warning

mem_cgroup_id_get() was introduced in commit 73f576c0 ("mm:memcontrol:
fix cgroup creation failure after many small jobs").

Later, it no longer has any user since the commits,

1f47b61f ("mm: memcontrol: fix swap counter leak on swapout from offline cgroup")
58fa2a55 ("mm: memcontrol: add sanity checks for memcg->id.ref on get/put")

so safe to remove it.

Link: http://lkml.kernel.org/r/1568648453-5482-1-git-send-email-cai@lca.pw


Signed-off-by: Qian Cai <cai@lca.pw>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 1eb41bb0

mm/memcontrol.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -4930,11 +4930,6 @@ static void mem_cgroup_id_put_many(struct mem_cgroup *memcg, unsigned int n)
		}
		}

		static inline void mem_cgroup_id_get(struct mem_cgroup *memcg)
		{
		mem_cgroup_id_get_many(memcg, 1);
		}

		static inline void mem_cgroup_id_put(struct mem_cgroup *memcg)
		{
		mem_cgroup_id_put_many(memcg, 1);

Admin message