Commit 4cfdcd9c authored Nov 04, 2015 by Dan Carpenter Committed by Alex Deucher Nov 04, 2015

drm/amdgpu: cleanup on error in amdgpu_cs_ioctl()



We recently changed the locking in this function and now there is a
missing unlock on error.  Also there are some other resources that we
should probably release as well...

Fixes: f48b2659 ('drm/amdgpu: fix the broken vm->mutex V2')
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

parent a7ca8ef9

drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -875,8 +875,10 @@ int amdgpu_cs_ioctl(struct drm_device dev, void data, struct drm_file *filp)
		struct amdgpu_job *job;
		struct amdgpu_ring * ring = parser->ibs->ring;
		job = kzalloc(sizeof(struct amdgpu_job), GFP_KERNEL);
		if (!job)
		return -ENOMEM;
		if (!job) {
		r = -ENOMEM;
		goto out;
		}
		job->base.sched = &ring->sched;
		job->base.s_entity = &parser->ctx->rings[ring->idx].entity;
		job->adev = parser->adev;

Admin message