Commit 4cda340a authored Apr 10, 2020 by Tang Bin Committed by Felipe Balbi May 25, 2020

usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()



If the function "platform_get_irq()" failed, the negative value
returned will not be detected here, including "-EPROBE_DEFER", which
causes the application to fail to get the correct error message.
Thus it must be fixed.

Acked-by: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>

parent 44734a59

drivers/usb/gadget/udc/fsl_udc_core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2440,8 +2440,8 @@ static int fsl_udc_probe(struct platform_device *pdev)
		udc_controller->max_ep = (dccparams & DCCPARAMS_DEN_MASK) * 2;

		udc_controller->irq = platform_get_irq(pdev, 0);
		if (!udc_controller->irq) {
		ret = -ENODEV;
		if (udc_controller->irq <= 0) {
		ret = udc_controller->irq ? : -ENODEV;
		goto err_iounmap;
		}

Admin message