scc_pata: fix module unloading (4cd7d924) · Commits · 戴 / test

scc_pata host driver predated module unloading support for IDE host drivers so even though it supports PCI hot-unplug and implements PCI device ->remove method it doesn't allow module removal. Fix it. Add missing __init/__exit tags to module_init/module_exit functions while at it (from Peter Huewe). Noticed-by:

Jiri Kosina <jkosina@suse.cz> Signed-off-by:

Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/ide/scc_pata.c

+5 −7

Original line number	Diff line number	Diff line
		@@ -872,20 +872,18 @@ static struct pci_driver scc_pci_driver = {
		.remove = __devexit_p(scc_remove),
		};

		static int scc_ide_init(void)
		static int __init scc_ide_init(void)
		{
		return ide_pci_register_driver(&scc_pci_driver);
		}

		module_init(scc_ide_init);
		/* -- No exit code?
		static void scc_ide_exit(void)
		static void __exit scc_ide_exit(void)
		{
		ide_pci_unregister_driver(&scc_pci_driver);
		pci_unregister_driver(&scc_pci_driver);
		}
		module_exit(scc_ide_exit);
		*/

		module_init(scc_ide_init);
		module_exit(scc_ide_exit);

		MODULE_DESCRIPTION("PCI driver module for Toshiba SCC IDE");
		MODULE_LICENSE("GPL");

Admin message