Commit 4ccd83f4 authored by Roi Dayan's avatar Roi Dayan Committed by Saeed Mahameed
Browse files

net/mlx5e: Use netdev_warn() instead of pr_err() for errors 



This is for added netdev prefix that helps identify
the source of the message.

Signed-off-by: default avatarRoi Dayan <roid@mellanox.com>
Reviewed-by: default avatarEli Cohen <eli@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 237ac8de

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+11 −6
Original line number Diff line number Diff line
@@ -3381,7 +3381,8 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, 
			if (attr->out_count >= MLX5_MAX_FLOW_FWD_VPORTS) {

				NL_SET_ERR_MSG_MOD(extack,

						   "can't support more output ports, can't offload forwarding");

				pr_err("can't support more than %d output ports, can't offload forwarding\n",

				netdev_warn(priv->netdev,

					    "can't support more than %d output ports, can't offload forwarding\n",

					    attr->out_count);

				return -EOPNOTSUPP;

			}
@@ -3460,8 +3461,10 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, 
				if (!mlx5e_is_valid_eswitch_fwd_dev(priv, out_dev)) {

					NL_SET_ERR_MSG_MOD(extack,

							   "devices are not on same switch HW, can't offload forwarding");

					pr_err("devices %s %s not on same switch HW, can't offload forwarding\n",

					       priv->netdev->name, out_dev->name);

					netdev_warn(priv->netdev,

						    "devices %s %s not on same switch HW, can't offload forwarding\n",

						    priv->netdev->name,

						    out_dev->name);

					return -EOPNOTSUPP;

				}
@@ -3480,8 +3483,10 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, 
			} else {

				NL_SET_ERR_MSG_MOD(extack,

						   "devices are not on same switch HW, can't offload forwarding");

				pr_err("devices %s %s not on same switch HW, can't offload forwarding\n",

				       priv->netdev->name, out_dev->name);

				netdev_warn(priv->netdev,

					    "devices %s %s not on same switch HW, can't offload forwarding\n",

					    priv->netdev->name,

					    out_dev->name);

				return -EINVAL;

			}

			}

CRA Git | Maintained and supported by SUSTech CRA and CCSE