Commit 4cc357c5 authored Dec 06, 2018 by Stefan Wahren Committed by Greg Kroah-Hartman Dec 12, 2018

staging: bcm2835-camera: Add hint about possible faulty config



As per default the GPU memory config of the Raspberry Pi isn't sufficient
for the camera usage. Even worse the bcm2835 camera driver doesn't provide a
helpful error message in this case. So let's add a hint to point the user
to the likely cause.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9c85a4d0

drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1623,8 +1623,11 @@ int vchiq_mmal_component_init(struct vchiq_mmal_instance *instance,
		component = &instance->component[instance->component_idx];

		ret = create_component(instance, component, name);
		if (ret < 0)
		if (ret < 0) {
		pr_err("%s: failed to create component %d (Not enough GPU mem?)\n",
		__func__, ret);
		goto unlock;
		}

		/* ports info needs gathering */
		component->control.type = MMAL_PORT_TYPE_CONTROL;

Admin message