iwlwifi: mvm: reset mvm->scan_type when firmware is started (4ca87a5f) · Commits · 戴 / test

If we don't reset the scan type when the firmware is started, we will think the firmware is still configured after the interface has been brought down. When we will bring it up again, we will not configure the scan type in firmware and it will crash with the following assert: 0x0000100A | ADVANCED_SYSASSERT Fixes: ("iwlwifi: mvm: configure scheduled scan according to traffic conditions") Signed-off-by:

Emmanuel Grumbach <emmanuel.grumbach@intel.com>

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -943,6 +943,7 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
		}

		if (fw_has_capa(&mvm->fw->ucode_capa, IWL_UCODE_TLV_CAPA_UMAC_SCAN)) {
		mvm->scan_type = IWL_SCAN_TYPE_NOT_SET;
		ret = iwl_mvm_config_scan(mvm);
		if (ret)
		goto error;

drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1002,7 +1002,6 @@ static void iwl_mvm_restart_cleanup(struct iwl_mvm *mvm)
		mvm->vif_count = 0;
		mvm->rx_ba_sessions = 0;
		mvm->fw_dbg_conf = FW_DBG_INVALID;
		mvm->scan_type = IWL_SCAN_TYPE_NOT_SET;

		/* keep statistics ticking */
		iwl_mvm_accu_radio_stats(mvm);

Admin message