dm raid: make sure no feature flags are set in metadata (4c9971ca) · Commits · 戴 / test

Given we don't yet support any feature flags in the dm-raid ondisk metadata (see: 'features' member of 'struct dm_raid_superblock'), add a check to ensure no flags are actually set, if any features are set reject the activation of the RAID mapping. This is to prevent possible data corruption in case of a kernel downgrade when there'll potentially be feature flags set by a future dm-raid target. Signed-off-by:

Heinz Mauelshagen <heinzm@redhat.com> Signed-off-by:

Mike Snitzer <snitzer@redhat.com>

drivers/md/dm-raid.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1037,6 +1037,11 @@ static int super_validate(struct raid_set rs, struct md_rdev rdev)
		if (!mddev->events && super_init_validation(mddev, rdev))
		return -EINVAL;

		if (le32_to_cpu(sb->features)) {
		rs->ti->error = "Unable to assemble array: No feature flags supported yet";
		return -EINVAL;
		}

		/* Enable bitmap creation for RAID levels != 0 */
		mddev->bitmap_info.offset = (rs->raid_type->level) ? to_sector(4096) : 0;
		rdev->mddev->bitmap_info.default_offset = mddev->bitmap_info.offset;
		@@ -1718,7 +1723,7 @@ static void raid_resume(struct dm_target *ti)

		static struct target_type raid_target = {
		.name = "raid",
		.version = {1, 7, 0},
		.version = {1, 8, 0},
		.module = THIS_MODULE,
		.ctr = raid_ctr,
		.dtr = raid_dtr,

Admin message