Commit 4c9337da authored by Jean Delvare's avatar Jean Delvare Committed by Greg Kroah-Hartman
Browse files

[PATCH] I2C: Centralize 24RF08 corruption prevention 



The 24RF08 corruption would better be prevented at i2c-core level than
at chip driver level, for several reasons:
* The second quick write should happen as soon as possible after the
  first one, so as to limit the risk that another command is issued on
  the bus inbetween, causing the corruption.
* As a matter of fact, the protection code at driver level was reworked
  at least three times already, which proves how hard it is to get it
  right there, while it's straightforward at i2c-core level.
* It's easy to add a new driver that would need the protection, and
  forget to add it. This did happen already.
* As additional probing addresses can be passed to most i2c chip drivers
  as module parameters, virtually every i2c chip driver would need the
  protection if we want to be really safe.
* Why duplicate code when we can easily avoid it?

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent a89ba0bc

Documentation/i2c/porting-clients

+2 −0
Original line number Diff line number Diff line
@@ -90,6 +90,8 @@ Technical changes: 
  device_create_file. Move the driver initialization before any

  sysfs file creation.

  Drop client->id.

  Drop any 24RF08 corruption prevention you find, as this is now done

  at the i2c-core level, and doing it twice voids it.



* [Init] Limits must not be set by the driver (can be done later in

  user-space). Chip should not be reset default (although a module

drivers/i2c/chips/eeprom.c

+0 −5
Original line number Diff line number Diff line
@@ -161,11 +161,6 @@ int eeprom_detect(struct i2c_adapter *adapter, int address, int kind) 
	struct eeprom_data *data;

	int err = 0;



	/* prevent 24RF08 corruption */

	if (kind < 0)

		i2c_smbus_xfer(adapter, address, 0, 0, 0,

			       I2C_SMBUS_QUICK, NULL);



	/* There are three ways we can read the EEPROM data:

	   (1) I2C block reads (faster, but unsupported by most adapters)

	   (2) Consecutive byte reads (100% overhead)

drivers/i2c/chips/max6875.c

+0 −5
Original line number Diff line number Diff line
@@ -171,11 +171,6 @@ static int max6875_detect(struct i2c_adapter *adapter, int address, int kind) 
	struct max6875_data *data;

	int err = 0;



	/* Prevent 24rf08 corruption (in case of user error) */

	if (kind < 0)

		i2c_smbus_xfer(adapter, address, 0, 0, 0,

			       I2C_SMBUS_QUICK, NULL);



	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WRITE_BYTE_DATA

				     | I2C_FUNC_SMBUS_READ_BYTE))

		return 0;

drivers/i2c/i2c-core.c

+10 −3
Original line number Diff line number Diff line
@@ -679,10 +679,17 @@ static int i2c_probe_address(struct i2c_adapter *adapter, int addr, int kind, 
		return 0;



	/* Make sure there is something at this address, unless forced */

	if (kind < 0

	 && i2c_smbus_xfer(adapter, addr, 0, 0, 0, I2C_SMBUS_QUICK, NULL) < 0)

	if (kind < 0) {

		if (i2c_smbus_xfer(adapter, addr, 0, 0, 0,

				   I2C_SMBUS_QUICK, NULL) < 0)

			return 0;



		/* prevent 24RF08 corruption */

		if ((addr & ~0x0f) == 0x50)

			i2c_smbus_xfer(adapter, addr, 0, 0, 0,

				       I2C_SMBUS_QUICK, NULL);

	}



	/* Finally call the custom detection function */

	err = found_proc(adapter, addr, kind);

CRA Git | Maintained and supported by SUSTech CRA and CCSE