qede: Disable hardware gro when xdp prog is installed (4c8dc005) · Commits · 戴 / test

commit ("qede: Use NETIF_F_GRO_HW.") introduced a regression in driver that when xdp program is installed on qede device, device's aggregation feature (hardware GRO) is not getting disabled, which is unexpected with xdp. Fixes: ("qede: Use NETIF_F_GRO_HW.") Signed-off-by:

Manish Chopra <manishc@marvell.com> Signed-off-by:

Ariel Elior <aelior@marvell.com> Reviewed-by:

Michael Chan <michael.chan@broadcom.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/qlogic/qede/qede_main.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1406,6 +1406,7 @@ static int qede_alloc_mem_rxq(struct qede_dev edev, struct qede_rx_queue rxq)
		rxq->rx_buf_seg_size = roundup_pow_of_two(size);
		} else {
		rxq->rx_buf_seg_size = PAGE_SIZE;
		edev->ndev->features &= ~NETIF_F_GRO_HW;
		}

		/* Allocate the parallel driver ring for Rx buffers */
		@@ -1450,6 +1451,7 @@ static int qede_alloc_mem_rxq(struct qede_dev edev, struct qede_rx_queue rxq)
		}
		}

		edev->gro_disable = !(edev->ndev->features & NETIF_F_GRO_HW);
		if (!edev->gro_disable)
		qede_set_tpa_param(rxq);
		err:
		@@ -1702,8 +1704,6 @@ static void qede_init_fp(struct qede_dev *edev)
		snprintf(fp->name, sizeof(fp->name), "%s-fp-%d",
		edev->ndev->name, queue_id);
		}

		edev->gro_disable = !(edev->ndev->features & NETIF_F_GRO_HW);
		}

		static int qede_set_real_num_queues(struct qede_dev *edev)

Admin message