Commit 4c6abef7 authored by Leonard Crestez's avatar Leonard Crestez Committed by Chanwoo Choi
Browse files

PM / devfreq: Fix handling dev_pm_qos_remove_request result 



The dev_pm_qos_remove_request function can return 1 if
"aggregated constraint value has changed" so only negative values should
be reported as errors.

Fixes: 27dbc542 ("PM / devfreq: Use PM QoS for sysfs min/max_freq")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLeonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 3bb5ee9a

drivers/devfreq/devfreq.c

+2 −2
Original line number Diff line number Diff line
@@ -705,13 +705,13 @@ static void devfreq_dev_release(struct device *dev) 


	if (dev_pm_qos_request_active(&devfreq->user_max_freq_req)) {

		err = dev_pm_qos_remove_request(&devfreq->user_max_freq_req);

		if (err)

		if (err < 0)

			dev_warn(dev->parent,

				"Failed to remove max_freq request: %d\n", err);

	}

	if (dev_pm_qos_request_active(&devfreq->user_min_freq_req)) {

		err = dev_pm_qos_remove_request(&devfreq->user_min_freq_req);

		if (err)

		if (err < 0)

			dev_warn(dev->parent,

				"Failed to remove min_freq request: %d\n", err);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE