Commit 4c58ed07 authored Oct 22, 2018 by Chao Yu Committed by Jaegeuk Kim Oct 22, 2018

f2fs: fix to account IO correctly



Below race can cause reversed reference on dirty count, fix it by
relocating __submit_bio() and inc_page_count().

Thread A				Thread B
- f2fs_inplace_write_data
 - f2fs_submit_page_bio
  - __submit_bio
					- f2fs_write_end_io
					 - dec_page_count
  - inc_page_count

Cc: <stable@vger.kernel.org>
Fixes: d1b3e72d ("f2fs: submit bio of in-place-update pages")
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

parent b93f654d

fs/f2fs/data.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -462,10 +462,10 @@ int f2fs_submit_page_bio(struct f2fs_io_info *fio)
		}
		bio_set_op_attrs(bio, fio->op, fio->op_flags);

		__submit_bio(fio->sbi, bio, fio->type);

		if (!is_read_io(fio->op))
		inc_page_count(fio->sbi, WB_DATA_TYPE(fio->page));

		__submit_bio(fio->sbi, bio, fio->type);
		return 0;
		}

Admin message