drm/amd/powerplay: not free hwmgr/smumgr in asic private functions. (4c283acf) · Commits · 戴 / test

struct smumgr/hwmgr will be freed on amd_powerplay_destory and if we free them in one of asic private functions, other private date may not be freed. for example: power state and power table in hwmgr. Signed-off-by:

Rex Zhu <Rex.Zhu@amd.com> Reviewed-by:

Alex Deucher <alexander.deucher@amd.com> Signed-off-by:

Alex Deucher <alexander.deucher@amd.com>

drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -1217,10 +1217,9 @@ static int cz_hwmgr_backend_init(struct pp_hwmgr *hwmgr)

		static int cz_hwmgr_backend_fini(struct pp_hwmgr *hwmgr)
		{
		if (hwmgr != NULL && hwmgr->backend != NULL) {
		if (hwmgr != NULL && hwmgr->backend != NULL)
		kfree(hwmgr->backend);
		kfree(hwmgr);
		}

		return 0;
		}

drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -831,7 +831,6 @@ static int cz_smu_fini(struct pp_smumgr *smumgr)
		cgs_free_gpu_mem(smumgr->device,
		cz_smu->smu_buffer.handle);
		kfree(cz_smu);
		kfree(smumgr);
		}

		return 0;

Admin message