Commit 4c172bbf authored by Oded Gabbay's avatar Oded Gabbay
Browse files

habanalabs: stop using the acronym KMD 



We want to stop using the acronym KMD. Therefore, replace all locations
(except for register names we can't modify) where KMD is written to other
terms such as "Linux kernel driver" or "Host kernel driver", etc.

Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
Reviewed-by: default avatarOmer Shpigelman <oshpigelman@habana.ai>
parent 0996bd1c

drivers/misc/habanalabs/asid.c

+1 −1
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ int hl_asid_init(struct hl_device *hdev) 


	mutex_init(&hdev->asid_mutex);



	/* ASID 0 is reserved for KMD and device CPU */

	/* ASID 0 is reserved for the kernel driver and device CPU */

	set_bit(0, hdev->asid_bitmap);



	return 0;

drivers/misc/habanalabs/command_buffer.c

+2 −1
Original line number Diff line number Diff line
@@ -397,7 +397,8 @@ struct hl_cb *hl_cb_kernel_create(struct hl_device *hdev, u32 cb_size) 
	rc = hl_cb_create(hdev, &hdev->kernel_cb_mgr, cb_size, &cb_handle,

			HL_KERNEL_ASID_ID);

	if (rc) {

		dev_err(hdev->dev, "Failed to allocate CB for KMD %d\n", rc);

		dev_err(hdev->dev,

			"Failed to allocate CB for the kernel driver %d\n", rc);

		return NULL;

	}

drivers/misc/habanalabs/command_submission.c

+3 −2
Original line number Diff line number Diff line
@@ -409,8 +409,9 @@ static struct hl_cb *validate_queue_index(struct hl_device *hdev, 
		return NULL;

	}



	if (hw_queue_prop->kmd_only) {

		dev_err(hdev->dev, "Queue index %d is restricted for KMD\n",

	if (hw_queue_prop->driver_only) {

		dev_err(hdev->dev,

			"Queue index %d is restricted for the kernel driver\n",

			chunk->queue_index);

		return NULL;

	} else if (hw_queue_prop->type == QUEUE_TYPE_INT) {

drivers/misc/habanalabs/context.c

+1 −1
Original line number Diff line number Diff line
@@ -128,7 +128,7 @@ int hl_ctx_init(struct hl_device *hdev, struct hl_ctx *ctx, bool is_kernel_ctx) 
	ctx->thread_ctx_switch_wait_token = 0;



	if (is_kernel_ctx) {

		ctx->asid = HL_KERNEL_ASID_ID; /* KMD gets ASID 0 */

		ctx->asid = HL_KERNEL_ASID_ID; /* Kernel driver gets ASID 0 */

		rc = hl_mmu_ctx_init(ctx);

		if (rc) {

			dev_err(hdev->dev, "Failed to init mmu ctx module\n");

drivers/misc/habanalabs/goya/goya.c

+11 −11
Original line number Diff line number Diff line
@@ -42,8 +42,8 @@ 
 * PQ, CQ and CP are not secured.

 * PQ, CB and the data are on the SRAM/DRAM.

 *

 * Since QMAN DMA is secured, KMD is parsing the DMA CB:

 *     - KMD checks DMA pointer

 * Since QMAN DMA is secured, the driver is parsing the DMA CB:

 *     - checks DMA pointer

 *     - WREG, MSG_PROT are not allowed.

 *     - MSG_LONG/SHORT are allowed.

 *
@@ -56,15 +56,15 @@ 
 * QMAN DMA: PQ, CQ and CP are secured.

 * MMU is set to bypass on the Secure props register of the QMAN.

 * The reasons we don't enable MMU for PQ, CQ and CP are:

 *     - PQ entry is in kernel address space and KMD doesn't map it.

 *     - PQ entry is in kernel address space and the driver doesn't map it.

 *     - CP writes to MSIX register and to kernel address space (completion

 *       queue).

 *

 * DMA is not secured but because CP is secured, KMD still needs to parse the

 * CB, but doesn't need to check the DMA addresses.

 * DMA is not secured but because CP is secured, the driver still needs to parse

 * the CB, but doesn't need to check the DMA addresses.

 *

 * For QMAN DMA 0, DMA is also secured because only KMD uses this DMA and KMD

 * doesn't map memory in MMU.

 * For QMAN DMA 0, DMA is also secured because only the driver uses this DMA and

 * the driver doesn't map memory in MMU.

 *

 * QMAN TPC/MME: PQ, CQ and CP aren't secured (no change from MMU disabled mode)

 *
@@ -336,18 +336,18 @@ void goya_get_fixed_properties(struct hl_device *hdev) 


	for (i = 0 ; i < NUMBER_OF_EXT_HW_QUEUES ; i++) {

		prop->hw_queues_props[i].type = QUEUE_TYPE_EXT;

		prop->hw_queues_props[i].kmd_only = 0;

		prop->hw_queues_props[i].driver_only = 0;

	}



	for (; i < NUMBER_OF_EXT_HW_QUEUES + NUMBER_OF_CPU_HW_QUEUES ; i++) {

		prop->hw_queues_props[i].type = QUEUE_TYPE_CPU;

		prop->hw_queues_props[i].kmd_only = 1;

		prop->hw_queues_props[i].driver_only = 1;

	}



	for (; i < NUMBER_OF_EXT_HW_QUEUES + NUMBER_OF_CPU_HW_QUEUES +

			NUMBER_OF_INT_HW_QUEUES; i++) {

		prop->hw_queues_props[i].type = QUEUE_TYPE_INT;

		prop->hw_queues_props[i].kmd_only = 0;

		prop->hw_queues_props[i].driver_only = 0;

	}



	for (; i < HL_MAX_QUEUES; i++)
@@ -2853,7 +2853,7 @@ static int goya_send_job_on_qman0(struct hl_device *hdev, struct hl_cs_job *job) 


	if (!hdev->asic_funcs->is_device_idle(hdev, NULL, NULL)) {

		dev_err_ratelimited(hdev->dev,

			"Can't send KMD job on QMAN0 because the device is not idle\n");

			"Can't send driver job on QMAN0 because the device is not idle\n");

		return -EBUSY;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE