net: core: dst_cache_set_ip6: Rename 'addr' parameter to 'saddr' for consistency (4c1342d9) · Commits · 戴 / test

The other dst_cache_{get,set}_ip{4,6} functions, and the doc comment for dst_cache_set_ip6 use 'saddr' for their source address parameter. Rename the parameter to increase consistency. This fixes the following kernel-doc warnings: ./include/net/dst_cache.h:58: warning: Function parameter or member 'addr' not described in 'dst_cache_set_ip6' ./include/net/dst_cache.h:58: warning: Excess function parameter 'saddr' description in 'dst_cache_set_ip6' Fixes: ("net: add dst_cache support") Signed-off-by:

Jonathan Neuschäfer <j.neuschaefer@gmx.net> Signed-off-by:

David S. Miller <davem@davemloft.net>

include/net/dst_cache.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -54,7 +54,7 @@ void dst_cache_set_ip4(struct dst_cache dst_cache, struct dst_entry dst,
		* local BH must be disabled.
		*/
		void dst_cache_set_ip6(struct dst_cache dst_cache, struct dst_entry dst,
		const struct in6_addr *addr);
		const struct in6_addr *saddr);

		/**
		* dst_cache_get_ip6 - perform cache lookup and fetch ipv6 source address

net/core/dst_cache.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -107,7 +107,7 @@ EXPORT_SYMBOL_GPL(dst_cache_set_ip4);

		#if IS_ENABLED(CONFIG_IPV6)
		void dst_cache_set_ip6(struct dst_cache dst_cache, struct dst_entry dst,
		const struct in6_addr *addr)
		const struct in6_addr *saddr)
		{
		struct dst_cache_pcpu *idst;

		@@ -117,7 +117,7 @@ void dst_cache_set_ip6(struct dst_cache dst_cache, struct dst_entry dst,
		idst = this_cpu_ptr(dst_cache->cache);
		dst_cache_per_cpu_dst_set(this_cpu_ptr(dst_cache->cache), dst,
		rt6_get_cookie((struct rt6_info *)dst));
		idst->in6_saddr = *addr;
		idst->in6_saddr = *saddr;
		}
		EXPORT_SYMBOL_GPL(dst_cache_set_ip6);

Admin message