Commit 4c11edfc authored May 07, 2019 by Masahiro Yamada

Remove MODULE_ALIAS() calls that take undefined macro



These files do not define (USBHS_)DRIVER_NAME. Yet, they can be
successfully compiled because they are never built as a module by
anyone, i.e, the MODULE_ALIAS() calls are always no-op.

A problem showed up when a patch "moduleparam: Save information about
built-in modules in separate file" was applied. With this new feature,
MODULE_*() will be populated even if the callers are built-in.

To avoid the build errors, the lines referencing to the undefined
macro must be removed.

The complete fix is to remove all MODULE_* and #include <linux/module.h>
like many "make ... explicitly non-modular" commits did.

For now, I am touching only the offending lines.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Tony Lindgren <tony@atomide.com>

parent 1e35663e

arch/arm/plat-omap/dma.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1449,7 +1449,6 @@ static void __exit omap_system_dma_exit(void)

		MODULE_DESCRIPTION("OMAP SYSTEM DMA DRIVER");
		MODULE_LICENSE("GPL");
		MODULE_ALIAS("platform:" DRIVER_NAME);
		MODULE_AUTHOR("Texas Instruments Inc");

		/*

drivers/clocksource/timer-ti-dm.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -998,5 +998,4 @@ module_platform_driver(omap_dm_timer_driver);

		MODULE_DESCRIPTION("OMAP Dual-Mode Timer Driver");
		MODULE_LICENSE("GPL");
		MODULE_ALIAS("platform:" DRIVER_NAME);
		MODULE_AUTHOR("Texas Instruments Inc");

drivers/mfd/omap-usb-tll.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -459,7 +459,6 @@ EXPORT_SYMBOL_GPL(omap_tll_disable);

		MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");
		MODULE_AUTHOR("Roger Quadros <rogerq@ti.com>");
		MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
		MODULE_LICENSE("GPL v2");
		MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI controllers");

Admin message