Commit 4c0d9b17 authored Feb 09, 2015 by Nicholas Mc Guire Committed by Greg Kroah-Hartman Mar 07, 2015

vt: vt_ioctl: use msecs_to_jiffies for time conversion



Converting milliseconds to jiffies by "val * HZ / 1000" is technically
OK but msecs_to_jiffies(val) is the cleaner solution and handles all
corner cases correctly. This is a minor API consolidation only and
should make things more readable.

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 833b1f7b

drivers/tty/vt/vt_ioctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -388,7 +388,7 @@ int vt_ioctl(struct tty_struct *tty,
		* Generate the tone for the appropriate number of ticks.
		* If the time is zero, turn off sound ourselves.
		*/
		ticks = HZ * ((arg >> 16) & 0xffff) / 1000;
		ticks = msecs_to_jiffies((arg >> 16) & 0xffff);
		count = ticks ? (arg & 0xffff) : 0;
		if (count)
		count = PIT_TICK_RATE / count;

Admin message