Commit 4c0d7cd5 authored Aug 09, 2018 by Al Viro

make sure that __dentry_kill() always invalidates d_seq, unhashed or not



RCU pathwalk relies upon the assumption that anything that changes
->d_inode of a dentry will invalidate its ->d_seq.  That's almost
true - the one exception is that the final dput() of already unhashed
dentry does *not* touch ->d_seq at all.  Unhashing does, though,
so for anything we'd found by RCU dcache lookup we are fine.
Unfortunately, we can *start* with an unhashed dentry or jump into
it.

We could try and be careful in the (few) places where that could
happen.  Or we could just make the final dput() invalidate the damn
thing, unhashed or not.  The latter is much simpler and easier to
backport, so let's do it that way.

Reported-by: "Dae R. Jeong" <threeearcat@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 119e1ef8

fs/dcache.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -358,13 +358,10 @@ static void dentry_unlink_inode(struct dentry * dentry)
		__releases(dentry->d_inode->i_lock)
		{
		struct inode *inode = dentry->d_inode;
		bool hashed = !d_unhashed(dentry);

		if (hashed)
		raw_write_seqcount_begin(&dentry->d_seq);
		__d_clear_type_and_inode(dentry);
		hlist_del_init(&dentry->d_u.d_alias);
		if (hashed)
		raw_write_seqcount_end(&dentry->d_seq);
		spin_unlock(&dentry->d_lock);
		spin_unlock(&inode->i_lock);

Admin message