ASoC: SOF: Intel: only support INFO_BATCH for legacy platforms (4c02a7bd) · Commits · 戴 / test

The current position update is not precise enough for PulseAudio to work reliably with the timer-based scheduling on Baytrail, Cherrytrail, Broadwell. Disable the NO_PERIOD_WAKEUP capability and use BATCH to signal that the position is only reliable and updated during period_elapsed events. This will be reverted when the firmware provides a more accurate position for those platforms. Reviewed-by:

Jaska Uimonen <jaska.uimonen@intel.com> Reviewed-by:

Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by:

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20191024210318.30068-3-pierre-louis.bossart@linux.intel.com Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/sof/intel/bdw.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -598,7 +598,7 @@ const struct snd_sof_dsp_ops sof_bdw_ops = {
		SNDRV_PCM_INFO_MMAP_VALID \|
		SNDRV_PCM_INFO_INTERLEAVED \|
		SNDRV_PCM_INFO_PAUSE \|
		SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
		SNDRV_PCM_INFO_BATCH,
		};
		EXPORT_SYMBOL(sof_bdw_ops);

sound/soc/sof/intel/byt.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -538,7 +538,7 @@ const struct snd_sof_dsp_ops sof_tng_ops = {
		SNDRV_PCM_INFO_MMAP_VALID \|
		SNDRV_PCM_INFO_INTERLEAVED \|
		SNDRV_PCM_INFO_PAUSE \|
		SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
		SNDRV_PCM_INFO_BATCH,
		};
		EXPORT_SYMBOL(sof_tng_ops);

		@@ -706,7 +706,7 @@ const struct snd_sof_dsp_ops sof_byt_ops = {
		SNDRV_PCM_INFO_MMAP_VALID \|
		SNDRV_PCM_INFO_INTERLEAVED \|
		SNDRV_PCM_INFO_PAUSE \|
		SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
		SNDRV_PCM_INFO_BATCH,
		};
		EXPORT_SYMBOL(sof_byt_ops);

		@@ -773,7 +773,7 @@ const struct snd_sof_dsp_ops sof_cht_ops = {
		SNDRV_PCM_INFO_MMAP_VALID \|
		SNDRV_PCM_INFO_INTERLEAVED \|
		SNDRV_PCM_INFO_PAUSE \|
		SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
		SNDRV_PCM_INFO_BATCH,
		};
		EXPORT_SYMBOL(sof_cht_ops);

Admin message