Commit 4be38e35 authored by Christoph Lameter's avatar Christoph Lameter Committed by Linus Torvalds
Browse files

[PATCH] mm: move determination of policy_zone into page allocator 



Currently the function to build a zonelist for a BIND policy has the side
effect to set the policy_zone.  This seems to be a bit strange.  policy
zone seems to not be initialized elsewhere and therefore 0.  Do we police
ZONE_DMA if no bind policy has been used yet?

This patch moves the determination of the zone to apply policies to into
the page allocator.  We determine the zone while building the zonelist for
nodes.

Signed-off-by: default avatarChristoph Lameter <clameter@sgi.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 1a93205b

include/linux/mempolicy.h

+11 −0
Original line number Diff line number Diff line
@@ -151,6 +151,14 @@ extern struct mempolicy default_policy; 
extern struct zonelist *huge_zonelist(struct vm_area_struct *vma,

		unsigned long addr);



extern int policy_zone;



static inline void check_highest_zone(int k)

{

	if (k > policy_zone)

		policy_zone = k;

}



#else



struct mempolicy {};
@@ -221,6 +229,9 @@ static inline struct zonelist *huge_zonelist(struct vm_area_struct *vma, 
	return NODE_DATA(0)->node_zonelists + gfp_zone(GFP_HIGHUSER);

}



static inline void check_highest_zone(int k)

{

}

#endif /* CONFIG_NUMA */

#endif /* __KERNEL__ */

mm/mempolicy.c

+3 −12
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ static kmem_cache_t *sn_cache; 


/* Highest zone. An specific allocation for a zone below that is not

   policied. */

static int policy_zone;

int policy_zone = ZONE_DMA;



struct mempolicy default_policy = {

	.refcnt = ATOMIC_INIT(1), /* never free it */
@@ -131,17 +131,8 @@ static struct zonelist *bind_zonelist(nodemask_t *nodes) 
	if (!zl)

		return NULL;

	num = 0;

	for_each_node_mask(nd, *nodes) {

		int k;

		for (k = MAX_NR_ZONES-1; k >= 0; k--) {

			struct zone *z = &NODE_DATA(nd)->node_zones[k];

			if (!z->present_pages)

				continue;

			zl->zones[num++] = z;

			if (k > policy_zone)

				policy_zone = k;

		}

	}

	for_each_node_mask(nd, *nodes)

		zl->zones[num++] = &NODE_DATA(nd)->node_zones[policy_zone];

	zl->zones[num] = NULL;

	return zl;

}

mm/page_alloc.c

+2 −0
Original line number Diff line number Diff line
@@ -36,6 +36,7 @@ 
#include <linux/memory_hotplug.h>

#include <linux/nodemask.h>

#include <linux/vmalloc.h>

#include <linux/mempolicy.h>



#include <asm/tlbflush.h>

#include "internal.h"
@@ -1470,6 +1471,7 @@ static int __init build_zonelists_node(pg_data_t *pgdat, 
			BUG_ON(zone - pgdat->node_zones > ZONE_NORMAL);

#endif

			zonelist->zones[j++] = zone;

			check_highest_zone(k);

		}

	}

	return j;

CRA Git | Maintained and supported by SUSTech CRA and CCSE