Commit 4be353d5 authored Aug 17, 2010 by Amit Kumar Salecha Committed by David S. Miller Aug 19, 2010

netxen: fix inconsistent lock state



Spin lock rds_ring->lock is used in poll routine, so other users should
use spin_lock_bh(). While posting rx buffers from netxen_nic_attach,
rds_ring->lock is not required, so cleaning it instead of fixing it by
spin_lock_bh().

Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0ac820ee

drivers/net/netxen/netxen_nic_init.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1805,8 +1805,6 @@ netxen_post_rx_buffers(struct netxen_adapter *adapter, u32 ringid,
		netxen_ctx_msg msg = 0;
		struct list_head *head;

		spin_lock(&rds_ring->lock);

		producer = rds_ring->producer;

		head = &rds_ring->free_list;
		@@ -1853,8 +1851,6 @@ netxen_post_rx_buffers(struct netxen_adapter *adapter, u32 ringid,
		NETXEN_RCV_PRODUCER_OFFSET), msg);
		}
		}

		spin_unlock(&rds_ring->lock);
		}

		static void

Admin message