Commit 4bd9b0f4 authored by Andy Adamson's avatar Andy Adamson Committed by J. Bruce Fields
Browse files

nfsd41: use globals for DRC limits 



The version 4.1 DRC memory limit and tracking variables are server wide and
session specific. Replace struct svc_serv fields with globals.
Stop using the svc_serv sv_lock.

Add a spinlock to serialize access to the DRC limit management variables which
change on session creation and deletion (usage counter) or (future)
administrative action to adjust the total DRC memory limit.

Signed-off-by: default avatarAndy Adamson <andros@netapp.com>
Signed-off-by: default avatarBenny Halevy <bhalevy@panasas.com>
parent 7702ce40

fs/nfsd/nfs4state.c

+5 −5
Original line number Diff line number Diff line
@@ -430,11 +430,11 @@ static int set_forechannel_maxreqs(struct nfsd4_channel_attrs *fchan) 
	else if (fchan->maxreqs > NFSD_MAX_SLOTS_PER_SESSION)

		fchan->maxreqs = NFSD_MAX_SLOTS_PER_SESSION;



	spin_lock(&nfsd_serv->sv_lock);

	if (np + nfsd_serv->sv_drc_pages_used > nfsd_serv->sv_drc_max_pages)

		np = nfsd_serv->sv_drc_max_pages - nfsd_serv->sv_drc_pages_used;

	nfsd_serv->sv_drc_pages_used += np;

	spin_unlock(&nfsd_serv->sv_lock);

	spin_lock(&nfsd_drc_lock);

	if (np + nfsd_drc_pages_used > nfsd_drc_max_pages)

		np = nfsd_drc_max_pages - nfsd_drc_pages_used;

	nfsd_drc_pages_used += np;

	spin_unlock(&nfsd_drc_lock);



	if (np <= 0) {

		status = nfserr_resource;

fs/nfsd/nfssvc.c

+15 −4
Original line number Diff line number Diff line
@@ -67,6 +67,16 @@ struct timeval nfssvc_boot; 
DEFINE_MUTEX(nfsd_mutex);

struct svc_serv 		*nfsd_serv;



/*

 * nfsd_drc_lock protects nfsd_drc_max_pages and nfsd_drc_pages_used.

 * nfsd_drc_max_pages limits the total amount of memory available for

 * version 4.1 DRC caches.

 * nfsd_drc_pages_used tracks the current version 4.1 DRC memory usage.

 */

spinlock_t	nfsd_drc_lock;

unsigned int	nfsd_drc_max_pages;

unsigned int	nfsd_drc_pages_used;



#if defined(CONFIG_NFSD_V2_ACL) || defined(CONFIG_NFSD_V3_ACL)

static struct svc_stat	nfsd_acl_svcstats;

static struct svc_version *	nfsd_acl_version[] = {
@@ -238,11 +248,12 @@ static void set_max_drc(void) 
{

	/* The percent of nr_free_buffer_pages used by the V4.1 server DRC */

	#define NFSD_DRC_SIZE_SHIFT	7

	nfsd_serv->sv_drc_max_pages = nr_free_buffer_pages()

	nfsd_drc_max_pages = nr_free_buffer_pages()

						>> NFSD_DRC_SIZE_SHIFT;

	nfsd_serv->sv_drc_pages_used = 0;

	dprintk("%s svc_drc_max_pages %u\n", __func__,

		nfsd_serv->sv_drc_max_pages);

	nfsd_drc_pages_used = 0;

	spin_lock_init(&nfsd_drc_lock);

	dprintk("%s nfsd_drc_max_pages %u\n", __func__,

		nfsd_drc_max_pages);

}



int nfsd_create_serv(void)

include/linux/nfsd/nfsd.h

+3 −0
Original line number Diff line number Diff line
@@ -56,6 +56,9 @@ extern struct svc_version nfsd_version2, nfsd_version3, 
extern u32			nfsd_supported_minorversion;

extern struct mutex		nfsd_mutex;

extern struct svc_serv		*nfsd_serv;

extern spinlock_t		nfsd_drc_lock;

extern unsigned int		nfsd_drc_max_pages;

extern unsigned int		nfsd_drc_pages_used;



extern struct seq_operations nfs_exports_op;

include/linux/sunrpc/svc.h

+0 −2
Original line number Diff line number Diff line
@@ -94,8 +94,6 @@ struct svc_serv { 
	struct module *		sv_module;	/* optional module to count when

						 * adding threads */

	svc_thread_fn		sv_function;	/* main function for threads */

	unsigned int		sv_drc_max_pages; /* Total pages for DRC */

	unsigned int		sv_drc_pages_used;/* DRC pages used */

#if defined(CONFIG_NFS_V4_1)

	struct list_head	sv_cb_list;	/* queue for callback requests

						 * that arrive over the same

CRA Git | Maintained and supported by SUSTech CRA and CCSE