Commit 4bd774e5 authored by Dave Martin's avatar Dave Martin Committed by Marc Zyngier
Browse files

KVM: arm64/sve: Simplify KVM_REG_ARM64_SVE_VLS array sizing 



A complicated DIV_ROUND_UP() expression is currently written out
explicitly in multiple places in order to specify the size of the
bitmap exchanged with userspace to represent the value of the
KVM_REG_ARM64_SVE_VLS pseudo-register.

Userspace currently has no direct way to work this out either: for
documentation purposes, the size is just quoted as 8 u64s.

To make this more intuitive, this patch replaces these with a
single define, which is also exported to userspace as
KVM_ARM64_SVE_VLS_WORDS.

Since the number of words in a bitmap is just the index of the last
word used + 1, this patch expresses the bound that way instead.
This should make it clearer what is being expressed.

For userspace convenience, the minimum and maximum possible vector
lengths relevant to the KVM ABI are exposed to UAPI as
KVM_ARM64_SVE_VQ_MIN, KVM_ARM64_SVE_VQ_MAX.  Since the only direct
use for these at present is manipulation of KVM_REG_ARM64_SVE_VLS,
no corresponding _VL_ macros are defined.  They could be added
later if a need arises.

Since use of DIV_ROUND_UP() was the only reason for including
<linux/kernel.h> in guest.c, this patch also removes that #include.

Suggested-by: default avatarAndrew Jones <drjones@redhat.com>
Signed-off-by: default avatarDave Martin <Dave.Martin@arm.com>
Reviewed-by: default avatarAndrew Jones <drjones@redhat.com>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent 55ffad3b

Documentation/virtual/kvm/api.txt

+6 −4
Original line number Diff line number Diff line
@@ -2171,13 +2171,15 @@ and KVM_ARM_VCPU_FINALIZE for more information about this procedure. 
KVM_REG_ARM64_SVE_VLS is a pseudo-register that allows the set of vector

lengths supported by the vcpu to be discovered and configured by

userspace.  When transferred to or from user memory via KVM_GET_ONE_REG

or KVM_SET_ONE_REG, the value of this register is of type __u64[8], and

encodes the set of vector lengths as follows:

or KVM_SET_ONE_REG, the value of this register is of type

__u64[KVM_ARM64_SVE_VLS_WORDS], and encodes the set of vector lengths as

follows:



__u64 vector_lengths[8];

__u64 vector_lengths[KVM_ARM64_SVE_VLS_WORDS];



if (vq >= SVE_VQ_MIN && vq <= SVE_VQ_MAX &&

    ((vector_lengths[(vq - 1) / 64] >> ((vq - 1) % 64)) & 1))

    ((vector_lengths[(vq - KVM_ARM64_SVE_VQ_MIN) / 64] >>

		((vq - KVM_ARM64_SVE_VQ_MIN) % 64)) & 1))

	/* Vector length vq * 16 bytes supported */

else

	/* Vector length vq * 16 bytes not supported */

arch/arm64/include/uapi/asm/kvm.h

+5 −0
Original line number Diff line number Diff line
@@ -258,9 +258,14 @@ struct kvm_vcpu_events { 
	 KVM_REG_SIZE_U256 |						\

	 ((i) & (KVM_ARM64_SVE_MAX_SLICES - 1)))



#define KVM_ARM64_SVE_VQ_MIN __SVE_VQ_MIN

#define KVM_ARM64_SVE_VQ_MAX __SVE_VQ_MAX



/* Vector lengths pseudo-register: */

#define KVM_REG_ARM64_SVE_VLS		(KVM_REG_ARM64 | KVM_REG_ARM64_SVE | \

					 KVM_REG_SIZE_U512 | 0xffff)

#define KVM_ARM64_SVE_VLS_WORDS	\

	((KVM_ARM64_SVE_VQ_MAX - KVM_ARM64_SVE_VQ_MIN) / 64 + 1)



/* Device Control API: ARM VGIC */

#define KVM_DEV_ARM_VGIC_GRP_ADDR	0

arch/arm64/kvm/guest.c

+3 −4
Original line number Diff line number Diff line
@@ -23,7 +23,6 @@ 
#include <linux/errno.h>

#include <linux/err.h>

#include <linux/nospec.h>

#include <linux/kernel.h>

#include <linux/kvm_host.h>

#include <linux/module.h>

#include <linux/stddef.h>
@@ -210,7 +209,7 @@ out: 
#define vq_mask(vq) ((u64)1 << ((vq) - SVE_VQ_MIN) % 64)



static bool vq_present(

	const u64 (*const vqs)[DIV_ROUND_UP(SVE_VQ_MAX - SVE_VQ_MIN + 1, 64)],

	const u64 (*const vqs)[KVM_ARM64_SVE_VLS_WORDS],

	unsigned int vq)

{

	return (*vqs)[vq_word(vq)] & vq_mask(vq);
@@ -219,7 +218,7 @@ static bool vq_present( 
static int get_sve_vls(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)

{

	unsigned int max_vq, vq;

	u64 vqs[DIV_ROUND_UP(SVE_VQ_MAX - SVE_VQ_MIN + 1, 64)];

	u64 vqs[KVM_ARM64_SVE_VLS_WORDS];



	if (!vcpu_has_sve(vcpu))

		return -ENOENT;
@@ -243,7 +242,7 @@ static int get_sve_vls(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg) 
static int set_sve_vls(struct kvm_vcpu *vcpu, const struct kvm_one_reg *reg)

{

	unsigned int max_vq, vq;

	u64 vqs[DIV_ROUND_UP(SVE_VQ_MAX - SVE_VQ_MIN + 1, 64)];

	u64 vqs[KVM_ARM64_SVE_VLS_WORDS];



	if (!vcpu_has_sve(vcpu))

		return -ENOENT;

CRA Git | Maintained and supported by SUSTech CRA and CCSE