Commit 4bb1b116 authored Nov 02, 2017 by Jiri Pirko Committed by David S. Miller Nov 03, 2017

net: sched: move block offload unbind after all chains are flushed



Currently, the offload unbind is done before the chains are flushed.
That causes driver to unregister block callback before it can get all
the callback calls done during flush, leaving the offloaded tps inside
the HW. So fix the order to prevent this situation and restore the
original behaviour.

Reported-by: Alexander Duyck <alexander.duyck@gmail.com>
Reported-by: Jakub Kicinski <kubakici@wp.pl>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9a7b96b3

net/sched/cls_api.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -343,11 +343,11 @@ void tcf_block_put_ext(struct tcf_block *block,
		if (!block)
		return;

		tcf_block_offload_unbind(block, q, ei);

		list_for_each_entry_safe(chain, tmp, &block->chain_list, list)
		tcf_chain_flush(chain);

		tcf_block_offload_unbind(block, q, ei);

		INIT_WORK(&block->work, tcf_block_put_final);
		/* Wait for existing RCU callbacks to cool down, make sure their works
		* have been queued before this. We can not flush pending works here

Admin message