Commit 4bab6909 authored Oct 06, 2020 by Chaitanya Kulkarni Committed by Christoph Hellwig Oct 07, 2020

nvme-core: put ctrl ref when module ref get fail



When try_module_get() fails in the nvme_dev_open() it returns without
releasing the ctrl reference which was taken earlier.

Put the ctrl reference which is taken before calling the
try_module_get() in the error return code path.

Fixes: 52a3974f "nvme-core: get/put ctrl and transport module in nvme_dev_open/release()"
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 6d53a9fe

drivers/nvme/host/core.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -3265,8 +3265,10 @@ static int nvme_dev_open(struct inode inode, struct file file)
		}

		nvme_get_ctrl(ctrl);
		if (!try_module_get(ctrl->ops->module))
		if (!try_module_get(ctrl->ops->module)) {
		nvme_put_ctrl(ctrl);
		return -EINVAL;
		}

		file->private_data = ctrl;
		return 0;

Admin message