Commit 4b97f8e1 authored Dec 20, 2010 by Dan Carpenter Committed by David S. Miller Dec 21, 2010

bnx2x: remove bogus check



We dereferenced params on the line before so it's too late to check if
params is NULL.  In fact, params can never be NULL and strict_cos is
either 0 or 1 so that part of the check is bogus too.  Let's remove it.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 70978182

drivers/net/bnx2x/bnx2x_link.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -354,9 +354,6 @@ u8 bnx2x_ets_strict(const struct link_params *params, const u8 strict_cos)
		struct bnx2x *bp = params->bp;
		u32 val = 0;

		if ((1 < strict_cos) && (NULL == params))
		return -EINVAL;

		DP(NETIF_MSG_LINK, "ETS enabled strict configuration\n");
		/**
		* Bitmap of 5bits length. Each bit specifies whether the entry behaves

Admin message