Commit 4b90a603 authored Nov 10, 2011 by Nick Bowler Committed by David S. Miller Nov 12, 2011

ah: Don't return NET_XMIT_DROP on input.



When the ahash driver returns -EBUSY, AH4/6 input functions return
NET_XMIT_DROP, presumably copied from the output code path.  But
returning transmit codes on input doesn't make a lot of sense.
Since NET_XMIT_DROP is a positive int, this gets interpreted as
the next header type (i.e., success).  As that can only end badly,
remove the check.

Signed-off-by: Nick Bowler <nbowler@elliptictech.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1e495701

net/ipv4/ah4.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -369,8 +369,6 @@ static int ah_input(struct xfrm_state x, struct sk_buff skb)
		if (err == -EINPROGRESS)
		goto out;

		if (err == -EBUSY)
		err = NET_XMIT_DROP;
		goto out_free;
		}

net/ipv6/ah6.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -581,8 +581,6 @@ static int ah6_input(struct xfrm_state x, struct sk_buff skb)
		if (err == -EINPROGRESS)
		goto out;

		if (err == -EBUSY)
		err = NET_XMIT_DROP;
		goto out_free;
		}

Admin message