Commit 4b8e1233 authored May 15, 2010 by Julia Lawall Committed by Greg Kroah-Hartman May 20, 2010

USB: gadget: Use kmemdup

Use kmemdup when some other buffer is immediately copied into the
allocated region.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression from,to,size,flag;
statement S;
@@

-  to = \(kmalloc\|kzalloc\)(size,flag);
+  to = kmemdup(from,size,flag);
   if (to==NULL || ...) S
-  memcpy(to, from, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent eefd9029

drivers/usb/gadget/atmel_usba_udc.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -48,10 +48,9 @@ static int queue_dbg_open(struct inode inode, struct file file)

		spin_lock_irq(&ep->udc->lock);
		list_for_each_entry(req, &ep->queue, queue) {
		req_copy = kmalloc(sizeof(*req_copy), GFP_ATOMIC);
		req_copy = kmemdup(req, sizeof(*req_copy), GFP_ATOMIC);
		if (!req_copy)
		goto fail;
		memcpy(req_copy, req, sizeof(*req_copy));
		list_add_tail(&req_copy->queue, queue_data);
		}
		spin_unlock_irq(&ep->udc->lock);

Admin message