Commit 4b86097b authored by Maxime Chevallier's avatar Maxime Chevallier Committed by David S. Miller
Browse files

net: mvpp2: fix RSS register definitions 



There is no RSS_TABLE register in PPv2 Controller. The register 0x1510
which was specified is actually named "RSS_HASH_SEL", but isn't used by
this driver at all.

Based on how this register was used, it should have been the
RXQ2RSS_TABLE register, which allows to select the RSS table that will
be used for the incoming packet.

The RSS_TABLE_POINTER is actually a field of this RXQ2RSS_TABLE
register.

Since RSS tables are actually not used by the driver for now, this
commit does not fix a runtime bug.

Signed-off-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 132baa03

drivers/net/ethernet/marvell/mvpp2/mvpp2.h

+2 −2
Original line number Diff line number Diff line
@@ -73,9 +73,9 @@ 
#define     MVPP22_RSS_INDEX_TABLE_ENTRY(idx)	(idx)

#define     MVPP22_RSS_INDEX_TABLE(idx)		((idx) << 8)

#define     MVPP22_RSS_INDEX_QUEUE(idx)		((idx) << 16)

#define MVPP22_RSS_TABLE_ENTRY			0x1508

#define MVPP22_RSS_TABLE			0x1510

#define MVPP22_RXQ2RSS_TABLE			0x1504

#define     MVPP22_RSS_TABLE_POINTER(p)		(p)

#define MVPP22_RSS_TABLE_ENTRY			0x1508

#define MVPP22_RSS_WIDTH			0x150c



/* Classifier Registers */

drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c

+1 −1
Original line number Diff line number Diff line
@@ -123,7 +123,7 @@ void mvpp22_init_rss(struct mvpp2_port *port) 
	 */

	for (i = 0; i < MVPP2_CLS_RX_QUEUES; i++) {

		mvpp2_write(priv, MVPP22_RSS_INDEX, MVPP22_RSS_INDEX_QUEUE(i));

		mvpp2_write(priv, MVPP22_RSS_TABLE,

		mvpp2_write(priv, MVPP22_RXQ2RSS_TABLE,

			    MVPP22_RSS_TABLE_POINTER(0));

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE