Commit 4b793acd authored Feb 28, 2020 by Taehee Yoo Committed by David S. Miller Feb 29, 2020

hsr: use netdev_err() instead of WARN_ONCE()



When HSR interface is sending a frame, it finds a node with
the destination ethernet address from the list.
If there is no node, it calls WARN_ONCE().
But, using WARN_ONCE() for this situation is a little bit overdoing.
So, in this patch, the netdev_err() is used instead.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 13eeb5fe

net/hsr/hsr_framereg.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -318,7 +318,8 @@ void hsr_addr_subst_dest(struct hsr_node node_src, struct sk_buff skb,
		node_dst = find_node_by_addr_A(&port->hsr->node_db,
		eth_hdr(skb)->h_dest);
		if (!node_dst) {
		WARN_ONCE(1, "%s: Unknown node\n", __func__);
		if (net_ratelimit())
		netdev_err(skb->dev, "%s: Unknown node\n", __func__);
		return;
		}
		if (port->type != node_dst->addr_B_port)

Admin message