Commit 4b78e201 authored Jun 07, 2020 by Jules Irenge Committed by Linus Torvalds Jun 08, 2020

ipc/msg: add missing annotation for freeque()



Sparse reports a warning at freeque()

warning: context imbalance in freeque() - unexpected unlock

The root cause is the missing annotation at freeque()

Add the missing __releases(RCU) annotation
Add the missing __releases(&msq->q_perm) annotation

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: Lu Shuaibing <shuaibinglu@126.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Link: http://lkml.kernel.org/r/20200403160505.2832-2-jbi.octave@gmail.com


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 92fb1db2

ipc/msg.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -268,6 +268,8 @@ static void expunge_all(struct msg_queue *msq, int res,
		* before freeque() is called. msg_ids.rwsem remains locked on exit.
		*/
		static void freeque(struct ipc_namespace ns, struct kern_ipc_perm ipcp)
		__releases(RCU)
		__releases(&msq->q_perm)
		{
		struct msg_msg msg, t;
		struct msg_queue *msq = container_of(ipcp, struct msg_queue, q_perm);

Admin message