ecryptfs: re-order a condition for static checkers (4b47a8b5) · Commits · 戴 / test

Static checkers complain that we are using "s->i" as an offset before we check whether it is within bounds. It doesn't matter much but we can easily swap the order of the checks to make everyone happy. Signed-off-by:

Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:

Tyler Hicks <tyhicks@canonical.com>

fs/ecryptfs/keystore.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1063,8 +1063,9 @@ ecryptfs_parse_tag_70_packet(char *filename, size_t filename_size,
		"rc = [%d]\n", __func__, rc);
		goto out_free_unlock;
		}
		while (s->decrypted_filename[s->i] != '\0'
		&& s->i < s->block_aligned_filename_size)

		while (s->i < s->block_aligned_filename_size &&
		s->decrypted_filename[s->i] != '\0')
		s->i++;
		if (s->i == s->block_aligned_filename_size) {
		printk(KERN_WARNING "%s: Invalid tag 70 packet; could not "

Admin message