Commit 4b25bbf5 authored Jun 15, 2020 by Coly Li Committed by Jens Axboe Jun 14, 2020

bcache: pr_info() format clean up in bcache_device_init()



scripts/checkpatch.pl reports following warning for patch
("bcache: check and adjust logical block size for backing devices"),
    WARNING: quoted string split across lines
    #146: FILE: drivers/md/bcache/super.c:896:
    +  pr_info("%s: sb/logical block size (%u) greater than page size "
    +	       "(%lu) falling back to device logical block size (%u)",

There are two things to fix up,
- The kernel message print should be in a single line.
- pr_info() won't automatically add new line since v5.8, a '\n' should
  be added.

This patch just does the above cleanup in bcache_device_init().

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent ee4a36f4

drivers/md/bcache/super.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -893,8 +893,7 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
		* This should only happen with BCACHE_SB_VERSION_BDEV.
		* Block/page size is checked for BCACHE_SB_VERSION_CDEV.
		*/
		pr_info("%s: sb/logical block size (%u) greater than page size "
		"(%lu) falling back to device logical block size (%u)",
		pr_info("%s: sb/logical block size (%u) greater than page size (%lu) falling back to device logical block size (%u)\n",
		d->disk->disk_name, q->limits.logical_block_size,
		PAGE_SIZE, bdev_logical_block_size(cached_bdev));

Admin message