Commit 4b07dd3d authored Aug 19, 2015 by Paul Gortmaker Committed by Greg Kroah-Hartman Oct 04, 2015

drivers/tty: make hvc_console.c explicitly non-modular



The Kconfig currently controlling compilation of this code is:

drivers/tty/hvc/Kconfig:config HVC_DRIVER
drivers/tty/hvc/Kconfig:        bool

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only, even
though someone bothered to comment that the code was not used.

Unlike other changes, this driver binds in w/o using module_init,
so we dont have init ordering concerns with this commit.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3bce6f64

drivers/tty/hvc/hvc_console.c

+1 −17

Original line number	Diff line number	Diff line
		@@ -29,7 +29,7 @@
		#include <linux/kernel.h>
		#include <linux/kthread.h>
		#include <linux/list.h>
		#include <linux/module.h>
		#include <linux/init.h>
		#include <linux/major.h>
		#include <linux/atomic.h>
		#include <linux/sysrq.h>
		@@ -1005,19 +1005,3 @@ put_tty:
		out:
		return err;
		}

		/* This isn't particularly necessary due to this being a console driver
		* but it is nice to be thorough.
		*/
		static void __exit hvc_exit(void)
		{
		if (hvc_driver) {
		kthread_stop(hvc_task);

		tty_unregister_driver(hvc_driver);
		/* return tty_struct instances allocated in hvc_init(). */
		put_tty_driver(hvc_driver);
		unregister_console(&hvc_console);
		}
		}
		module_exit(hvc_exit);

Admin message