Commit 4ae94025 authored by Boris Brezillon's avatar Boris Brezillon Committed by Miquel Raynal
Browse files

mtd: rawnand: Leave chip->IO_ADDR_{R, W} to NULL when unused 



There's no point in poisoning the ->IO_ADDR_{R,W}, a NULL pointer
is just as good to detect unexpected ->IO_ADDR_{R,W} usage.

Signed-off-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent 800342de

drivers/mtd/nand/raw/brcmnand/brcmnand.c

+0 −3
Original line number Diff line number Diff line
@@ -2270,9 +2270,6 @@ static int brcmnand_init_cs(struct brcmnand_host *host, struct device_node *dn) 
	mtd->owner = THIS_MODULE;

	mtd->dev.parent = &pdev->dev;



	chip->IO_ADDR_R = (void __iomem *)0xdeadbeef;

	chip->IO_ADDR_W = (void __iomem *)0xdeadbeef;



	chip->cmd_ctrl = brcmnand_cmd_ctrl;

	chip->cmdfunc = brcmnand_cmdfunc;

	chip->waitfunc = brcmnand_waitfunc;

drivers/mtd/nand/raw/socrates_nand.c

+0 −4
Original line number Diff line number Diff line
@@ -152,10 +152,6 @@ static int socrates_nand_probe(struct platform_device *ofdev) 
	mtd->name = "socrates_nand";

	mtd->dev.parent = &ofdev->dev;



	/*should never be accessed directly */

	nand_chip->IO_ADDR_R = (void *)0xdeadbeef;

	nand_chip->IO_ADDR_W = (void *)0xdeadbeef;



	nand_chip->cmd_ctrl = socrates_nand_cmd_ctrl;

	nand_chip->read_byte = socrates_nand_read_byte;

	nand_chip->write_buf = socrates_nand_write_buf;

CRA Git | Maintained and supported by SUSTech CRA and CCSE