Commit 4ae28944 authored Oct 15, 2007 by Pavel Emelyanov Committed by David S. Miller Oct 15, 2007

[NEIGH]: Ensure that pneigh_lookup is protected with RTNL



The pnigh_lookup is used to lookup proxy entries and to 
create them in case lookup failed. 

However, the "creation" code does not perform the re-lookup
after GFP_KERNEL allocation. This is done because the code
is expected to be protected with the RTNL lock, so add the 
assertion (mainly to address future questions from new network 
developers like me :) ).

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f1673ca5

net/core/neighbour.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -481,6 +481,8 @@ struct pneigh_entry * pneigh_lookup(struct neigh_table tbl, const void pkey,
		if (!creat)
		goto out;

		ASSERT_RTNL();

		n = kmalloc(sizeof(*n) + key_len, GFP_KERNEL);
		if (!n)
		goto out;

Admin message