Commit 4adc0423 authored Nov 06, 2019 by Arnd Bergmann Committed by Mauro Carvalho Chehab Nov 09, 2019

media: venus: remove invalid compat_ioctl32 handler



v4l2_compat_ioctl32() is the function that calls into
v4l2_file_operations->compat_ioctl32(), so setting that back to the same
function leads to a trivial endless loop, followed by a kernel
stack overrun.

Remove the incorrect assignment.

Cc: stable@vger.kernel.org
Fixes: 7472c1c6 ("[media] media: venus: vdec: add video decoder files")
Fixes: aaaa93ed ("[media] media: venus: venc: add video encoder files")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

parent 1076df3a

drivers/media/platform/qcom/venus/vdec.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1416,9 +1416,6 @@ static const struct v4l2_file_operations vdec_fops = {
		.unlocked_ioctl = video_ioctl2,
		.poll = v4l2_m2m_fop_poll,
		.mmap = v4l2_m2m_fop_mmap,
		#ifdef CONFIG_COMPAT
		.compat_ioctl32 = v4l2_compat_ioctl32,
		#endif
		};

		static int vdec_probe(struct platform_device *pdev)

drivers/media/platform/qcom/venus/venc.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1239,9 +1239,6 @@ static const struct v4l2_file_operations venc_fops = {
		.unlocked_ioctl = video_ioctl2,
		.poll = v4l2_m2m_fop_poll,
		.mmap = v4l2_m2m_fop_mmap,
		#ifdef CONFIG_COMPAT
		.compat_ioctl32 = v4l2_compat_ioctl32,
		#endif
		};

		static int venc_probe(struct platform_device *pdev)

Admin message