Commit 4acdaf27 authored by Al Viro's avatar Al Viro
Browse files

switch ->create() to umode_t 



vfs_create() ignores everything outside of 16bit subset of its
mode argument; switching it to umode_t is obviously equivalent
and it's the only caller of the method

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 18bb1db3

Documentation/filesystems/Locking

+1 −1
Original line number Diff line number Diff line
@@ -37,7 +37,7 @@ d_manage: no no yes (ref-walk) maybe 


--------------------------- inode_operations --------------------------- 

prototypes:

	int (*create) (struct inode *,struct dentry *,int, struct nameidata *);

	int (*create) (struct inode *,struct dentry *,umode_t, struct nameidata *);

	struct dentry * (*lookup) (struct inode *,struct dentry *, struct nameid

ata *);

	int (*link) (struct dentry *,struct inode *,struct dentry *);

Documentation/filesystems/vfs.txt

+1 −1
Original line number Diff line number Diff line
@@ -341,7 +341,7 @@ This describes how the VFS can manipulate an inode in your 
filesystem. As of kernel 2.6.22, the following members are defined:



struct inode_operations {

	int (*create) (struct inode *,struct dentry *,int, struct nameidata *);

	int (*create) (struct inode *,struct dentry *, umode_t, struct nameidata *);

	struct dentry * (*lookup) (struct inode *,struct dentry *, struct nameidata *);

	int (*link) (struct dentry *,struct inode *,struct dentry *);

	int (*unlink) (struct inode *,struct dentry *);

drivers/staging/pohmelfs/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -661,7 +661,7 @@ static int pohmelfs_create_entry(struct inode *dir, struct dentry *dentry, u64 s 
/*

 * VFS create and mkdir callbacks.

 */

static int pohmelfs_create(struct inode *dir, struct dentry *dentry, int mode,

static int pohmelfs_create(struct inode *dir, struct dentry *dentry, umode_t mode,

		struct nameidata *nd)

{

	return pohmelfs_create_entry(dir, dentry, 0, mode);

fs/9p/vfs_inode.c

+1 −1
Original line number Diff line number Diff line
@@ -702,7 +702,7 @@ error: 
 */



static int

v9fs_vfs_create(struct inode *dir, struct dentry *dentry, int mode,

v9fs_vfs_create(struct inode *dir, struct dentry *dentry, umode_t mode,

		struct nameidata *nd)

{

	int err;

fs/9p/vfs_inode_dotl.c

+2 −2
Original line number Diff line number Diff line
@@ -253,7 +253,7 @@ int v9fs_open_to_dotl_flags(int flags) 
 */



static int

v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, int omode,

v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, umode_t omode,

		struct nameidata *nd)

{

	int err = 0;
@@ -284,7 +284,7 @@ v9fs_vfs_create_dotl(struct inode *dir, struct dentry *dentry, int omode, 


	name = (char *) dentry->d_name.name;

	P9_DPRINTK(P9_DEBUG_VFS, "v9fs_vfs_create_dotl: name:%s flags:0x%x "

			"mode:0x%x\n", name, flags, omode);

			"mode:0x%hx\n", name, flags, omode);



	dfid = v9fs_fid_lookup(dentry->d_parent);

	if (IS_ERR(dfid)) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE