kconfig: check for pkg-config on make {menu,n,g,x}config (4ab3b801) · Commits · 戴 / test

Each of 'make {menu,n,g,x}config' uses (needs) pkg-config to make sure that other required files are present and to determine build flags settings, but none of these check that pkg-config itself is present. Add a check for all 4 of these targets and update Documentation/process/changes.rst to mention 'pkg-config'. Fixes kernel bugzilla #77511: https://bugzilla.kernel.org/show_bug.cgi?id=77511 Signed-off-by:

Randy Dunlap <rdunlap@infradead.org> Cc: Bjørn Forsman <bjorn.forsman@gmail.com> Signed-off-by:

Masahiro Yamada <yamada.masahiro@socionext.com>

Documentation/process/changes.rst

+8 −0

Original line number	Diff line number	Diff line
		@@ -81,6 +81,14 @@ The build system has, as of 4.13, switched to using thin archives (`ar T`)
		rather than incremental linking (`ld -r`) for built-in.a intermediate steps.
		This requires binutils 2.20 or newer.

		pkg-config
		----------

		The build system, as of 4.18, requires pkg-config to check for installed
		kconfig tools and to determine flags settings for use in
		'make {menu,n,g,x}config'. Previously pkg-config was being used but not
		verified or documented.

		Flex
		----

scripts/kconfig/Makefile

+1 −0

Original line number	Diff line number	Diff line
		@@ -215,6 +215,7 @@ $(obj)/zconf.tab.o: $(obj)/zconf.lex.c

		# check if necessary packages are available, and configure build flags
		define filechk_conf_cfg
		$(CONFIG_SHELL) $(srctree)/scripts/kconfig/check-pkgconfig.sh; \
		$(CONFIG_SHELL) $<
		endef

scripts/kconfig/check-pkgconfig.sh

0 → 100644

+8 −0

Original line number	Diff line number	Diff line
		#!/bin/sh
		# SPDX-License-Identifier: GPL-2.0
		# Check for pkg-config presence

		if [ -z $(command -v pkg-config) ]; then
		echo "'make *config' requires 'pkg-config'. Please install it." 1>&2
		exit 1
		fi

Admin message