Commit 4aafe9c6 authored Jul 15, 2017 by Julia Lawall Committed by Stephen Boyd Jul 17, 2017

clk: mmp: Drop unnecessary static

Drop static on a local variable, when the variable is initialized before
any possible use.  Thus, the static has no benefit.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

parent c8108cf2

drivers/clk/mmp/clk.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -9,7 +9,7 @@
		void mmp_clk_init(struct device_node np, struct mmp_clk_unit unit,
		int nr_clks)
		{
		static struct clk **clk_table;
		struct clk **clk_table;

		clk_table = kcalloc(nr_clks, sizeof(struct clk *), GFP_KERNEL);
		if (!clk_table)

Admin message