Commit 4aaf0878 authored Jul 17, 2008 by Lee Nipper Committed by Herbert Xu Jul 17, 2008

crypto: talitos - Remove calls to of_node_put

Remove of_node_put calls since there is no corresponding of_node_get.
This patch prevents an exception when talitos is loaded a 2nd time.
This sequence: modprobe talitos; rmmod talitos; modprobe talitos
causes this message: "WARNING: Bad of_node_put() on /soc8349@e0000000/crypto@30000".

Signed-off-by: Lee Nipper <lee.nipper@freescale.com>
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 33af79d1

drivers/crypto/talitos.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -1466,9 +1466,6 @@ static int talitos_probe(struct of_device *ofdev,
		goto err_out;
		}

		of_node_put(np);
		np = NULL;

		priv->head_lock = kmalloc(sizeof(spinlock_t) * priv->num_channels,
		GFP_KERNEL);
		priv->tail_lock = kmalloc(sizeof(spinlock_t) * priv->num_channels,
		@@ -1559,8 +1556,6 @@ static int talitos_probe(struct of_device *ofdev,

		err_out:
		talitos_remove(ofdev);
		if (np)
		of_node_put(np);

		return err;
		}

Admin message