Commit 4aac6c5a authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman
Browse files

greybus: svc: Use -EIO instead of -EINVAL for unipro errors 



-EIO fits better here, rather than -EINVAL as the arguments to the
routine itself are valid, just that we failed while doing unipro
transfers.

Suggested-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent c5b6df9c

drivers/staging/greybus/svc.c

+2 −2
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ int gb_svc_dme_peer_get(struct gb_svc *svc, u8 intf_id, u16 attr, u16 selector, 
	if (result) {

		dev_err(&svc->dev, "UniPro error while getting DME attribute (%hhu %hx %hu): %hu\n",

				intf_id, attr, selector, result);

		return -EINVAL;

		return -EIO;

	}



	if (value)
@@ -130,7 +130,7 @@ int gb_svc_dme_peer_set(struct gb_svc *svc, u8 intf_id, u16 attr, u16 selector, 
	if (result) {

		dev_err(&svc->dev, "UniPro error while setting DME attribute (%hhu %hx %hu %u): %hu\n",

				intf_id, attr, selector, value, result);

		return -EINVAL;

		return -EIO;

	}



	return 0;

CRA Git | Maintained and supported by SUSTech CRA and CCSE