Commit 4aa5b78f authored Dec 14, 2020 by Zhen Lei Committed by Rob Herring Dec 14, 2020

dt-bindings: i2c: dw: cancel mandatory requirements for "#address-cells" and "#size-cells"



The "#address-cells" and "#size-cells" are required only when the I2C
controller has subnodes. However, some I2C controllers defined in
"arch/arm64/boot/dts/amd/" and "arch/arm64/boot/dts/hisilicon/"
directories do not have child nodes. So they don't need these two
properties and don't write them explicitly.

Therefore, setting properties "#address-cells" and "#size-cells" as
"required" in this yaml file causes the following warnings:
/root/linux-next/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dt.yaml: \
i2c@f7100000: '#address-cells' is a required property
/root/linux-next/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dt.yaml: \
i2c@f7100000: '#size-cells' is a required property

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20201214124347.2120-2-thunder.leizhen@huawei.com


Signed-off-by: Rob Herring <robh@kernel.org>

parent a217d871

Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml

+0 −8

Original line number	Diff line number	Diff line
		@@ -101,8 +101,6 @@ unevaluatedProperties: false
		required:
		- compatible
		- reg
		- "#address-cells"
		- "#size-cells"
		- interrupts

		examples:
		@@ -110,8 +108,6 @@ examples:
		i2c@f0000 {
		compatible = "snps,designware-i2c";
		reg = <0xf0000 0x1000>;
		#address-cells = <1>;
		#size-cells = <0>;
		interrupts = <11>;
		clock-frequency = <400000>;
		};
		@@ -119,8 +115,6 @@ examples:
		i2c@1120000 {
		compatible = "snps,designware-i2c";
		reg = <0x1120000 0x1000>;
		#address-cells = <1>;
		#size-cells = <0>;
		interrupts = <12 1>;
		clock-frequency = <400000>;
		i2c-sda-hold-time-ns = <300>;
		@@ -148,8 +142,6 @@ examples:
		reg = <0x100400 0x100>, <0x198 0x8>;
		pinctrl-0 = <&i2c_pins>;
		pinctrl-names = "default";
		#address-cells = <1>;
		#size-cells = <0>;
		interrupts = <8>;
		clocks = <&ahb_clk>;
		};

Admin message