Commit 4a9d9167 authored Oct 30, 2008 by Jonathan McDowell Committed by John W. Linville Nov 06, 2008

Fix logic error in rfkill_check_duplicity



> I'll have a prod at why the [hso] rfkill stuff isn't working next

Ok, I believe this is due to the addition of rfkill_check_duplicity in
rfkill and the fact that test_bit actually returns a negative value
rather than the postive one expected (which is of course equally true).
So when the second WLAN device (the hso device, with the EEE PC WLAN
being the first) comes along rfkill_check_duplicity returns a negative
value and so rfkill_register returns an error. Patch below fixes this
for me.

Signed-Off-By: Jonathan McDowell <noodles@earth.li>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 964d2777

net/rfkill/rfkill.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -603,7 +603,7 @@ static int rfkill_check_duplicity(const struct rfkill *rfkill)
		}

		/* 0: first switch of its kind */
		return test_bit(rfkill->type, seen);
		return (test_bit(rfkill->type, seen)) ? 1 : 0;
		}

		static int rfkill_add_switch(struct rfkill *rfkill)

Admin message