Commit 4a883ccf authored Jan 03, 2020 by YueHaibing Committed by David S. Miller Jan 03, 2020

ethtool: remove set but not used variable 'lsettings'



Fixes gcc '-Wunused-but-set-variable' warning:

net/ethtool/linkmodes.c: In function 'ethnl_set_linkmodes':
net/ethtool/linkmodes.c:326:32: warning:
 variable 'lsettings' set but not used [-Wunused-but-set-variable]
  struct ethtool_link_settings *lsettings;
                                ^
It is never used, so remove it.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d0e8bcaf

net/ethtool/linkmodes.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -323,7 +323,6 @@ int ethnl_set_linkmodes(struct sk_buff skb, struct genl_info info)
		{
		struct nlattr *tb[ETHTOOL_A_LINKMODES_MAX + 1];
		struct ethtool_link_ksettings ksettings = {};
		struct ethtool_link_settings *lsettings;
		struct ethnl_req_info req_info = {};
		struct net_device *dev;
		bool mod = false;
		@@ -354,7 +353,6 @@ int ethnl_set_linkmodes(struct sk_buff skb, struct genl_info info)
		GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
		goto out_ops;
		}
		lsettings = &ksettings.base;

		ret = ethnl_update_linkmodes(info, tb, &ksettings, &mod);
		if (ret < 0)

Admin message