Commit 4a705c5c authored Jun 09, 2015 by Aleksa Sarai Committed by Tejun Heo Jun 10, 2015

cgroup: fix uninitialised iterator in for_each_subsys_which



Fix the fact that @ssid is uninitialised in the case where
CGROUP_SUBSYS_COUNT = 0 by setting ssid to 0.

Fixes: cb4a3167 ("cgroup: use bitmask to filter for_each_subsys")
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent a966a4ed

kernel/cgroup.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -424,7 +424,7 @@ static int notify_on_release(const struct cgroup *cgrp)
		*/
		#define for_each_subsys_which(ss, ssid, ss_maskp) \
		if (!CGROUP_SUBSYS_COUNT) /* to avoid spurious gcc warning */ \
		; \
		(ssid) = 0; \
		else \
		for_each_set_bit(ssid, ss_maskp, CGROUP_SUBSYS_COUNT) \
		if (((ss) = cgroup_subsys[ssid]) && false) \

Admin message