Commit 4a5e3638 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Andi Kleen
Browse files

ACPI: stop complaints about interrupt link End Tags and blank IRQ descriptors 

Silently ignore _PRS End Tags.  We already ignore Start Dependent Functions in
_PRS, and we already ignore End Tags in _CRS, so we might as well ignore End
Tags in _PRS as well.

Silently ignore _PRS IRQ descriptors that mention no interrupts.  The spec
allows this (section 6.4.2.1 in ACPI 3.0b spec), and it probably means the
interrupt link can't be configured at all.

This patch doesn't change any functional behavior; it just removes confusing
complaints like these:

    ACPI: Blank IRQ resource
    ACPI: Resource is not an IRQ entry

when parsing _PRS data "23 00 00 18 79 00" from an IBM xSeries 335 dual
Pentium IV Xeon 2.40 GHz machine.  For more details, see
    http://bugzilla.kernel.org/show_bug.cgi?id=11049



The "23 00 00 18" part is a three-byte-long small IRQ resource with no bits set
in the IRQ mask ("00 00"), and level-triggered, active low, shareable ("18").

The "79 00" is an End Tag (type 0x7).  It is superfluous since there is no
Start Dependent Function tag and there are no resources after it, but it is
harmless.

Thanks to Gabriele Trombetti <g.trombetti.lkrnl1213@logicschema.com>
(aka Kurk) for reporting this and testing the patch.

Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
parent 5b664cb2

drivers/acpi/pci_link.c

+20 −11
Original line number Diff line number Diff line
@@ -113,19 +113,22 @@ acpi_pci_link_check_possible(struct acpi_resource *resource, void *context) 


	switch (resource->type) {

	case ACPI_RESOURCE_TYPE_START_DEPENDENT:

	case ACPI_RESOURCE_TYPE_END_TAG:

		return AE_OK;

	case ACPI_RESOURCE_TYPE_IRQ:

		{

			struct acpi_resource_irq *p = &resource->data.irq;

			if (!p || !p->interrupt_count) {

				printk(KERN_WARNING PREFIX "Blank IRQ resource\n");

				ACPI_DEBUG_PRINT((ACPI_DB_INFO,

						  "Blank _PRS IRQ resource\n"));

				return AE_OK;

			}

			for (i = 0;

			     (i < p->interrupt_count

			      && i < ACPI_PCI_LINK_MAX_POSSIBLE); i++) {

				if (!p->interrupts[i]) {

					printk(KERN_WARNING PREFIX "Invalid IRQ %d\n",

					printk(KERN_WARNING PREFIX

					       "Invalid _PRS IRQ %d\n",

					       p->interrupts[i]);

					continue;

				}
@@ -143,14 +146,15 @@ acpi_pci_link_check_possible(struct acpi_resource *resource, void *context) 
			    &resource->data.extended_irq;

			if (!p || !p->interrupt_count) {

				printk(KERN_WARNING PREFIX

					      "Blank EXT IRQ resource\n");

					      "Blank _PRS EXT IRQ resource\n");

				return AE_OK;

			}

			for (i = 0;

			     (i < p->interrupt_count

			      && i < ACPI_PCI_LINK_MAX_POSSIBLE); i++) {

				if (!p->interrupts[i]) {

					printk(KERN_WARNING PREFIX "Invalid IRQ %d\n",

					printk(KERN_WARNING PREFIX

					       "Invalid _PRS IRQ %d\n",

					       p->interrupts[i]);

					continue;

				}
@@ -163,7 +167,8 @@ acpi_pci_link_check_possible(struct acpi_resource *resource, void *context) 
			break;

		}

	default:

		printk(KERN_ERR PREFIX "Resource is not an IRQ entry\n");

		printk(KERN_ERR PREFIX "_PRS resource type 0x%x isn't an IRQ\n",

		       resource->type);

		return AE_OK;

	}
@@ -199,6 +204,9 @@ acpi_pci_link_check_current(struct acpi_resource *resource, void *context) 




	switch (resource->type) {

	case ACPI_RESOURCE_TYPE_START_DEPENDENT:

	case ACPI_RESOURCE_TYPE_END_TAG:

		return AE_OK;

	case ACPI_RESOURCE_TYPE_IRQ:

		{

			struct acpi_resource_irq *p = &resource->data.irq;
@@ -208,7 +216,7 @@ acpi_pci_link_check_current(struct acpi_resource *resource, void *context) 
				 * particularly those those w/ _STA disabled

				 */

				ACPI_DEBUG_PRINT((ACPI_DB_INFO,

						  "Blank IRQ resource\n"));

						  "Blank _CRS IRQ resource\n"));

				return AE_OK;

			}

			*irq = p->interrupts[0];
@@ -224,7 +232,7 @@ acpi_pci_link_check_current(struct acpi_resource *resource, void *context) 
				 * return at least 1 IRQ

				 */

				printk(KERN_WARNING PREFIX

					      "Blank EXT IRQ resource\n");

					      "Blank _CRS EXT IRQ resource\n");

				return AE_OK;

			}

			*irq = p->interrupts[0];
@@ -232,10 +240,11 @@ acpi_pci_link_check_current(struct acpi_resource *resource, void *context) 
		}

		break;

	default:

		printk(KERN_ERR PREFIX "Resource %d isn't an IRQ\n", resource->type);

	case ACPI_RESOURCE_TYPE_END_TAG:

		printk(KERN_ERR PREFIX "_CRS resource type 0x%x isn't an IRQ\n",

		       resource->type);

		return AE_OK;

	}



	return AE_CTRL_TERMINATE;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE