Commit 4a4b8831 authored Jul 31, 2007 by J. Bruce Fields Committed by Linus Torvalds Jul 31, 2007

knfsd: eliminate unnecessary -ENOENT returns on export downcalls

A succesful downcall with a negative result (which indicates that the given
filesystem is not exported to the given user) should not return an error.

Currently mountd is depending on stdio to write these downcalls. With some
versions of libc this appears to cause subsequent writes to attempt to write
all accumulated data (for which writes previously failed) along with any new
data. This can prevent the kernel from seeing responses to later downcalls.
Symptoms will be that nfsd fails to respond to certain requests.

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Cc: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0a725fc4

fs/nfsd/export.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -564,9 +564,10 @@ static int svc_export_parse(struct cache_detail cd, char mesg, int mlen)

		/* flags */
		err = get_int(&mesg, &an_int);
		if (err == -ENOENT)
		if (err == -ENOENT) {
		err = 0;
		set_bit(CACHE_NEGATIVE, &exp.h.flags);
		else {
		} else {
		if (err \|\| an_int < 0) goto out;
		exp.ex_flags= an_int;

Admin message