Commit 4a43d686 authored Sep 28, 2013 by Tomasz Figa Committed by Grant Likely Oct 15, 2013

of/irq: Pass trigger type in IRQ resource flags



Some drivers might rely on availability of trigger flags in IRQ
resource, for example to configure the hardware for particular interrupt
type. However current code creating IRQ resources from data in device
tree does not configure trigger flags in resulting resources.

This patch tries to solve the problem, based on the fact that
irq_of_parse_and_map() configures the trigger based on DT interrupt
specifier and IRQD_TRIGGER_* flags are consistent with IORESOURCE_IRQ_*,
and we can get correct trigger flags by calling irqd_get_trigger_type()
after mapping the interrupt.

Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
[grant.likely: Merged the two assignments to r->flags]
Signed-off-by: Grant Likely <grant.likely@linaro.org>

parent 8804827b

drivers/of/irq.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -354,7 +354,7 @@ int of_irq_to_resource(struct device_node dev, int index, struct resource r)
	&name);		&name);

	r->start = r->end = irq;		r->start = r->end = irq;
	r->flags = IORESOURCE_IRQ;		r->flags = IORESOURCE_IRQ \| irqd_get_trigger_type(irq_get_irq_data(irq));
	r->name = name ? name : of_node_full_name(dev);		r->name = name ? name : of_node_full_name(dev);
	}		}

Admin message